main: don't mutate compile options in Test - #5468
Merged
Merged
Conversation
eliasnaur
approved these changes
Jun 17, 2026
Comment on lines
+212
to
+213
| optionsCopy := *options | ||
| options = &optionsCopy |
Contributor
There was a problem hiding this comment.
This fix works, but leaves the footgun. If it weren't for its size, compileopts.Options should be passed by value.
Member
Author
There was a problem hiding this comment.
It probably wouldn't be a big deal to just make it a value arg; either way it's going to get copied...
Member
|
Since it does improve the current code it is a step in the correct direction. We can discuss changing the interface to pass by value in a future PR. Now merging, thanks for the fix @jakebailey and to @eliasnaur for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function modifies TestConfig, but Test is called from multiple places, so can cause a data race. (and in the presence of races, all behavior bets are off).