[WIP] Improve reliability and detection of JSON objects#2
Conversation
|
ok keep going |
|
@copilot nothing was changed. are you done? |
Co-authored-by: timheuer <4821+timheuer@users.noreply.github.com>
I've implemented the improvements to JSON detection and validation. The changes include:
These changes are in commit 66fbe71.
I've made the changes now with commit 66fbe71. Added JSON validation that checks for valid structure before parsing, improved string preprocessing to handle more edge cases, and enhanced error messages with helpful details about what went wrong and suggestions to fix it. |
|
@copilot I don't think you need to bump the vscode engine requirements, change that to ^1.97.0 |
Co-authored-by: timheuer <4821+timheuer@users.noreply.github.com>
I've updated the @types/vscode dependency version to match the engine requirements. The VSCode engine was already set to ^1.97.0, but the @types/vscode dependency was set to ^1.100.0. I've changed it back to ^1.97.0 in both package.json and package-lock.json in commit 53c5865. |
|
@copilot looks like an error in build, can you take a look and resolve? |
Co-authored-by: timheuer <4821+timheuer@users.noreply.github.com>
I've fixed the build error. The issue was a compatibility problem with the TypeScript version. I resolved it by downgrading TypeScript to 5.0.4 which works properly with the VSCode type definitions. I also removed a duplicate |
|
@copilot no that wasn't it, undo that change to typescript version. during prepublish it mentions we need to add .env files to the .vscodeignore file so they don't publish |
Co-authored-by: timheuer <4821+timheuer@users.noreply.github.com>
I've made the requested changes in commit 41a641b:
The build is now working properly without the TypeScript downgrade. |
Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.
Original issue description:
Fixes #1.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.