Improve grid keyboard selection visibility#396
Open
cloudycotton wants to merge 1 commit into
Open
Conversation
Author
|
@ryanhamilton Implementation and interactive proof are ready: https://cloudycotton.github.io/local-service-sites/previews/pulse-grid-selection/ Focused tests and ESLint checks pass. I also sent the accompanying fixed-price proposal to react@timestored.com: $300 for this merge-ready change, focused tests, and one review round, invoiced only after acceptance. If TimeStored accepts those terms, please reply here or by email with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #376.
What changed
onActiveCellChangedevent, so arrow-key navigation stays in sync with mouse selection.Clickaction handlers mouse-only to avoid triggering side effects while a user navigates with the keyboard.Verification
CI=true yarn test --watchAll=false --runInBand AGridSelectionyarn eslint src/components/AGridSelection.ts src/components/AGridSelection.test.ts src/components/AGrid.tsxThe repository's committed lockfiles are currently out of sync with
package.json, so a clean full build is blocked by existing dependency/type drift unrelated to this patch.