New Red theme added - #2
Open
eleazardavidmr wants to merge 1 commit into
Open
Conversation
tiflu
requested changes
Jan 22, 2026
tiflu
left a comment
Owner
There was a problem hiding this comment.
Hi, the added changes look good... But, it looks like you also reformatted most of the code, probably through some kind of reformatter that your IDE has. This makes it difficult to see the actual changes.
A pull request should typically have a concise theme or goal. This one should only do what's needed to add a new theme to the timer.
How the code is formatted is typically up to the person or organization that runs the repo, and more advanced projects may have a style guide for reference. Regardless of which is more readable/better, a major overhaul to reformatting like this should be its own pull request, not put together with a style addition.
Here's what I recommend:
- Copy and paste the relevant changes in the html/js into a text file (notepad, etc.)
- Revert this commit
- Paste the relevant changes back
- Make a new commit(s) with only the relevant changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a red theme for the timer.
