Skip to content

New Red theme added - #2

Open
eleazardavidmr wants to merge 1 commit into
tiflu:masterfrom
eleazardavidmr:addNewTheme
Open

New Red theme added#2
eleazardavidmr wants to merge 1 commit into
tiflu:masterfrom
eleazardavidmr:addNewTheme

Conversation

@eleazardavidmr

Copy link
Copy Markdown

I've added a red theme for the timer.
Screenshot from 2026-01-22 11-27-57

@tiflu tiflu left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the added changes look good... But, it looks like you also reformatted most of the code, probably through some kind of reformatter that your IDE has. This makes it difficult to see the actual changes.
A pull request should typically have a concise theme or goal. This one should only do what's needed to add a new theme to the timer.
How the code is formatted is typically up to the person or organization that runs the repo, and more advanced projects may have a style guide for reference. Regardless of which is more readable/better, a major overhaul to reformatting like this should be its own pull request, not put together with a style addition.

Here's what I recommend:

  1. Copy and paste the relevant changes in the html/js into a text file (notepad, etc.)
  2. Revert this commit
  3. Paste the relevant changes back
  4. Make a new commit(s) with only the relevant changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants