test: add cluster equivalence tests for tidy/glance.fixest#1278
Closed
LeonidasZhak wants to merge 1 commit into
Closed
test: add cluster equivalence tests for tidy/glance.fixest#1278LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
Add tests verifying that tidy(fit, cluster=...) and glance(fit, cluster=...) produce the same results as tidying/summarizing a pre-clustered summary object. Complements PR tidymodels#1276 which added cluster/vcov tests for tidy but not glance.
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests verifying that
tidy(fit, cluster=...)andglance(fit, cluster=...)produce the same results as tidying/summarizing a pre-clusteredsummary.fixestobject.Problem
The existing test-fixest.R tests
tidy()andglance()withse = "hetero"equivalence against a pre-summarized object, but the same pattern was not tested for theclusterargument. This means the cluster-pass-through behavior of bothtidy.fixestandglance.fixestwas untested.Fix
Added a test block inside the existing "tidiers work with model results or summary of model results" test that:
summary(fit2, cluster = c("id", "v1"))tidy(fit2, cluster = ...)matchestidy(fit2_clust)tidy(fit2, cluster = ..., conf.int = TRUE)matchesglance(fit2, cluster = ...)matchesglance(fit2_clust)Relation to PR #1276
PR #1276 added dedicated test blocks for the
clusterandvcovarguments ontidy.fixest. This PR adds the missingglance.fixestcluster equivalence test. The two PRs are complementary and do not conflict.Validation
Files changed
tests/testthat/test-fixest.R— 9 lines added