fix: detect NA count by length instead of name in tidy.summaryDefault#1277
Open
LeonidasZhak wants to merge 1 commit into
Open
fix: detect NA count by length instead of name in tidy.summaryDefault#1277LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
R-devel (PR#18948) changes the 'NA.s' label in summary() output.
The old code checked for specific name strings ('NA.s', 'NAs'),
which breaks when the label changes. Instead, detect the NA count
column by comparing ncol(ret) to the expected base column count.
Fixes tidymodels#1259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tidy.summaryDefault()breaks in R-devel because it relies on the name"NA's"insummary()output to detect the NA count row. R-devel (PR#18948) changes this label, causing a size mismatch error:Fixes #1259.
Fix
Instead of checking for specific name strings (
"NA's","NAs"), detect the NA count column by comparingncol(ret)to the expected base column count (6). This is robust to any future label changes.Changes
R/deprecated-0-7-0.R: Replace name-based check with length-based checkValidation
"NA's"is the label: works correctly