Skip to content

qbittorrent: support HTTP 204 login responses - #3250

Open
harababurel wants to merge 1 commit into
tidbyt:mainfrom
harababurel:fix-qbittorrent-login-204
Open

qbittorrent: support HTTP 204 login responses#3250
harababurel wants to merge 1 commit into
tidbyt:mainfrom
harababurel:fix-qbittorrent-login-204

Conversation

@harababurel

Copy link
Copy Markdown

Summary

  • accept HTTP 204 as a successful qBittorrent login response
  • preserve support for older versions that return Ok.
  • continue rejecting unsuccessful login responses

qBittorrent now sends 204 when a successful WebAPI response contains no data. The app currently checks only for an Ok. response body, so valid logins are displayed as Login failed :(.

Testing

  • pixlet check apps/qbittorrent/qbittorrent.star

@tidbyt

tidbyt Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
🟡 Original Author The original author (DoubleGremlin181) does not match the PR author (harababurel)

@tidbyt-bot

tidbyt-bot commented Jul 31, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@harababurel

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@harababurel

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants