test(release): remove the descendant-kill timing race - #64
Merged
thequantumfalcon merged 1 commit intoAug 15, 2026
Merged
Conversation
The tree-kill regression left under a second between the 1s timeout and the descendant's write, so a loaded Windows runner that took longer to complete taskkill /T reported a survivor. The descendant now sleeps well past the timeout and the assertion waits past its write time, so a survivor would still have written: the property is unchanged and the margin is five seconds instead of one. Signed-off-by: Thomas Albrecht <thequantumfalcon@users.noreply.github.com> (cherry picked from commit 2b45e0535f2fb73dc14e70a442d68fb77ec1b322)
thequantumfalcon
deleted the
series/19-remove-the-descendant-kill-timing-race
branch
August 15, 2026 04:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree-kill regression left under a second between the 1s timeout and
the descendant's write, so a loaded Windows runner that took longer to
complete taskkill /T reported a survivor. The descendant now sleeps well
past the timeout and the assertion waits past its write time, so a
survivor would still have written: the property is unchanged and the
margin is five seconds instead of one.
Landed from a rehearsed series: verified from a clean exact-HEAD checkout with
its focused regressions, the complete suite, the artifacts leg, and the
attribution, secret and DCO checks; the composed series reproduces the reviewed
candidate byte-for-byte.