Skip to content

Enable website building for new version releases #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FanwangM wants to merge 3 commits into from
Closed

Enable website building for new version releases #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b837ab
Enable website building for new version releases
FanwangM Dec 7, 2025
e0cbace
Enable workflow dispatch
FanwangM Dec 7, 2025
ecf8a6d
Clean up website.yaml
FanwangM Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/website.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ on:
push:
branches:
- main

tags:
# Trigger on version tags (e.g., v1.0.0)
- "v[0-9].[0-9].[0-9]*"
- "[0-9].[0-9].[0-9]*"
# Trigger on pre-release tags (e.g., v1.0.0-alpha.1)
- "v[0-9].[0-9].[0-9]*-*"
- "[0-9].[0-9].[0-9]*-*"
Comment on lines +9 to +13

Copilot AI Dec 7, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag patterns will only match versions where the major and minor version numbers are single digits (0-9). For example, v10.0.0 or v1.15.0 won't trigger the workflow.

Consider updating the patterns to support multi-digit version numbers:

- "v[0-9]+.[0-9]+.[0-9]+"
- "[0-9]+.[0-9]+.[0-9]+"
# For pre-release tags
- "v[0-9]+.[0-9]+.[0-9]+-*"
- "[0-9]+.[0-9]+.[0-9]+-*"

This ensures all valid semantic version tags will trigger the workflow, not just those with single-digit major and minor versions.

Suggested change
- "v[0-9].[0-9].[0-9]*"
- "[0-9].[0-9].[0-9]*"
# Trigger on pre-release tags (e.g., v1.0.0-alpha.1)
- "v[0-9].[0-9].[0-9]*-*"
- "[0-9].[0-9].[0-9]*-*"
- "v[0-9]+.[0-9]+.[0-9]+"
- "[0-9]+.[0-9]+.[0-9]+"
# Trigger on pre-release tags (e.g., v1.0.0-alpha.1)
- "v[0-9]+.[0-9]+.[0-9]+-*"
- "[0-9]+.[0-9]+.[0-9]+-*"

Copilot uses AI. Check for mistakes.
pull_request:
branches:
- main
workflow_dispatch:

permissions:
contents: write
Expand Down Expand Up @@ -47,10 +57,10 @@ jobs:
git submodule update --init --recursive
pip install .[docs]

- name: Install pandoc
uses: pandoc/actions/setup@v1
- name: Run pandoc
run: pandoc --version
- name: Setup pandoc
uses: siacodelabs/setup-pandoc@v1
with:
xelatex: true

# didn't need to change anything here, but had to add sphinx.ext.githubpages
# to my conf.py extensions list. that fixes the broken uploads
Expand All @@ -62,7 +72,7 @@ jobs:
# still need to build and set the PAT to get a rebuild on the pages job,
# apart from that quite clean and nice
- name: GitHub Pages Action
#if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
Loading