Replace optics-based JSON traversal with lightweight custom helpers#70
Merged
Conversation
Drop the aeson-optics and optics-core dependencies in favor of a small TestContainers.Docker.JSON module that provides lookupKey, asText, asBool, asInteger, eachMember, and eachValue for navigating aeson Value trees. Adds scientific and vector as direct dependencies instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexbiehl
force-pushed
the
alex/no-optics
branch
from
e668e7d to
70b10f8
Compare
LaurentRDC
approved these changes
Mar 31, 2026
LaurentRDC
left a comment
LaurentRDC
left a comment
Collaborator
There was a problem hiding this comment.
This is wonderful! aeson-optics maintenance has been on the slow side these past few years. Thanks for taking care of this
Collaborator
Author
|
@LaurentRDC Yeah, I felt it was time for this step. Can you maybe push a release if you got time? Don't worry if not, I probably get to it end of week. |
Collaborator
|
I'll make a release right now |
Collaborator
Collaborator
Author
|
Thank you sir! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the aeson-optics and optics-core dependencies in favor of a small
TestContainers.Docker.JSON module that provides lookupKey, asText, asBool,
asInteger, eachMember, and eachValue for navigating aeson Value trees.
Adds scientific and vector as direct dependencies instead.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com