[Scheduler] Log decisions and task events via the EventLog#10530
Merged
Conversation
lina-temporal
commented
Jun 4, 2026
| s.EventLog.Get(ctx).LogEvent(ctx, fmt.Sprintf("unpaused via API: %s", req.FrontendRequest.Patch.Unpause)) | ||
| } | ||
|
|
||
| if err := s.handlePatch(ctx, req.FrontendRequest.Patch); err != nil { |
Contributor
Author
There was a problem hiding this comment.
This also does generate a log entry, by virtue of each backfiller added generating a log entry.
davidporter-id-au
approved these changes
Jun 4, 2026
chaptersix
reviewed
Jun 4, 2026
Contributor
chaptersix
left a comment
chaptersix
left a comment
There was a problem hiding this comment.
Do you plan on adding logs for: UpdateSchedule, PatchSchedule, create from migration, and when there's no callbacks to attach to workflows?
Contributor
|
generally LGTM |
Contributor
Author
All of these are present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks