Change VisibilityRow execution duration type to int64#10524
Open
rodrigozhou wants to merge 1 commit into
Open
Conversation
5 tasks
Contributor
Author
|
PR #10529 has a quick fix without changing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Change
VisibilityRow.ExecutionDurationtype from*time.Durationto*int64.Why?
time.Durationis not always translated correctly to integer values when inserting into the database (eg:jackc/pgxmodule with connection attributesdefault_query_exec_mode: simple_protocoltranslatestime.Durationinto a string instead of an integer).Furthermore, the VisibilityRow is meant to represent the values from DB, so making it
int64also makes it more explicitly.#10514
How did you test it?
Potential risks
Users implementing their own
VisibilityStorebased on the SQL implementation which uses theVisibilityRowmight need to double check their code.