DLQ CHASM pure task if valid after execution, add unit test verifications to test framework#10502
Open
awln-temporal wants to merge 3 commits into
Open
DLQ CHASM pure task if valid after execution, add unit test verifications to test framework#10502awln-temporal wants to merge 3 commits into
awln-temporal wants to merge 3 commits into
Conversation
…ions to test framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
If pure task is still valid after execution, we throw a new task error and move the task to DLQ to avoid stuck executions. Also adds unit test verifications to the framework.
Why?
Task Validation checks if a task should be executed by running a Predicate on the component state. Pure tasks should not be valid after execution, but as of now, there is no such verifications in place to prevent a task from remaining valid after execution, leading to stuck executions. The logical task remains in the CHASM tree, and no other physical task is generated.
How did you test it?