Remove childInfo.NamespaceId backfill code#10501
Open
andreahlert wants to merge 1 commit into
Open
Conversation
The NamespaceId field was added to ChildExecutionInfo in May 2022 (commit 738b36f). All new child workflows since then have the field populated. The backward compatibility fallback code that looked up the namespace by name when NamespaceId was empty is no longer necessary. This removes the fallback from: - processParentClosePolicy batch processing - applyParentClosePolicy for TERMINATE - applyParentClosePolicy for REQUEST_CANCEL Also removes now-unnecessary namespace cache mocks from tests. Signed-off-by: André Ahlert <andre@aex.partners>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Remove backward compatibility fallback for
childInfo.NamespaceIdin parent close policy processing.Why?
TODOs (by @alexshtin) have been in the codebase for 3+ years. The team has a pattern of removing backward compatibility code after shorter periods (e.g., PR #3330 and #3329 in Sep 2022 removed deprecated namespace fields just months after
namespace_idwas introduced).How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
No.