Remove redundant default-worker activity registration#10499
Open
NasitSony wants to merge 1 commit into
Open
Conversation
Upgrade-compat shim from temporalio#5017, marked for removal in 1.24. Now on 1.30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade-compat shim from #5017, marked for removal in 1.24. Now on 1.30.
What changed?
Removed a redundant
wc.RegisterActivities(defaultWorker)call and its stale TODO in the dedicated-activity-worker branch ofworkerManager.Start().Why?
The double-registration was an upgrade/downgrade compatibility measure added in #5017 (Oct 2023) and explicitly marked for removal in the 1.24 release. The current release line is 1.30, so the mixed-version window it protected has long since closed. Components that request a dedicated activity worker already register their activities on that dedicated worker, so the additional registration on the default worker is redundant.
How did you test it?
Potential risks
During a rolling upgrade from a pre-1.24 server, an old host could still enqueue a dedicated-worker component's activity tasks on the default task queue. The 1.24 → 1.30 gap is well beyond the supported upgrade-skew window, so supported upgrade paths are unaffected.