Adds search based on link owner - #213
Conversation
parkr
left a comment
parkr
left a comment
There was a problem hiding this comment.
Drive-by comment for your Wednesday! Please ignore unless it provides value to you.
| } | ||
|
|
||
| sort.Slice(links, func(i, j int) bool { | ||
| return links[i].Short < links[j].Short |
There was a problem hiding this comment.
Shouldn't sorting be user-defined? I might want to change the sorting (e.g. to created date) in the UI. Should that be supported?
There was a problem hiding this comment.
Hey Parker! 👋🏻
eventually, yes probably. Tim and I talked a lot about what future features we might want to build in the search endpoint and whittled that down to a simple first feature that was pretty straightforward to implement, and could easily be extended to support additional search operators in the future.
Custom sort will be a good thing to add as well, including on the existing /.all page. In fact, I'm expecting that /.all will pretty quickly just become a redirect for /.search, since it's basically just search without any query to limit the results.
| query := r.URL.Query().Get("q") | ||
| owner, found := strings.CutPrefix(query, "owner:") | ||
| if !found { | ||
| http.Error(w, `search only supports "owner:<email>"`, http.StatusBadRequest) |
There was a problem hiding this comment.
need a return after this, so that it doesn't also try to render the page. For example, try loading the /.search page without any query.
There was a problem hiding this comment.
just went ahead and fixed this myself.
add search endpoint with support for owner filtering, the all page now uses the search template with the expectation that all becomes a "search" once search is fully implemented updates #98 Signed-off-by: Tim Walters <tim@tailscale.com>
d72801e to
94de873
Compare
| query := r.URL.Query().Get("q") | ||
| owner, found := strings.CutPrefix(query, "owner:") | ||
| if !found { | ||
| http.Error(w, `search only supports "owner:<email>"`, http.StatusBadRequest) |
There was a problem hiding this comment.
just went ahead and fixed this myself.
3 participants
add search endpoint with support for owner filtering, the all page now uses the search template with the expectation that all becomes a "search" once search is fully implemented
updates #98