Skip to content

feat: add legal links to the home website#1288

Open
Arsabutispik wants to merge 3 commits into
mainfrom
feat/add-legal-links
Open

feat: add legal links to the home website#1288
Arsabutispik wants to merge 3 commits into
mainfrom
feat/add-legal-links

Conversation

@Arsabutispik

@Arsabutispik Arsabutispik commented Jun 20, 2026

Copy link
Copy Markdown
Member

Adds the legal links introduced to the root payload to the home page
Fixes #565

How was this PR tested?

  • Saw the correct links being displayed

Screenshots & Screencasts (if appropriate)

image

Checklist:

  • I have carefully read the contributing guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR
  • I have confirmed that any new dependencies are strictly necessary
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

Please declare, if any, LLM usage involved in creating this PR

No AI was used

@Arsabutispik Arsabutispik requested review from a team as code owners June 20, 2026 19:35
Signed-off-by: İspik <ispik@ispik.dev>
@Arsabutispik Arsabutispik force-pushed the feat/add-legal-links branch from 50dddc7 to 9b3092f Compare June 20, 2026 19:36
Comment thread packages/client/src/interface/Home.tsx Outdated
</CategoryButton>
</SeparatedColumn>
</Buttons>
<Show when={client()!.configuration?.features.legal_links}>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration object is not reactive. That means that you must use the configured signal, and change your values to something like this:

client().configured() ? client()!.configuration?.features.legal_links : undefined

This makes solid react to the configuration value changing. Otherwise, these values will never actually show up until after a refresh.

You can see an example of this in the invite_only code in account registration.

Comment thread packages/client/src/interface/Home.tsx Outdated
Signed-off-by: İspik <ispik@ispik.dev>
@Dadadah Dadadah added the waiting for next release This should be merged after the next release label Jun 21, 2026

@infi infi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the links on the login page are not enough? What apps show the legal links inside the app after login? Most don't do this as they are irrelevant most of the time and can be easily pulled up on the website if need arises.

Signed-off-by: İspik <ispik@ispik.dev>
@Arsabutispik Arsabutispik requested review from Dadadah and infi June 21, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for next release This should be merged after the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: point users to instance ToS and community guidelines

3 participants