feat: show headset mic for voice channel mentions#1251
Conversation
Display the "headset_mic" icon for voice channel mentions, rather than the same "tag" - Makes it easier to distinguish channel types and provides a more friendly UI. Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
|
I think this needs UI/UX review |
There was a problem hiding this comment.
Ideally icons per channel type should be centrally defined, hardcoding it in more places is not a good idea for long term maintenance ability. Merging this change as it is would make this harder however. Can this PR be expanded to define constants instead of hardcoded strings?
@infi Additionally; Do you want me to expand this PR beyond just the two files and add these constants into ServerSidebar & ChannelHeader? or, keep it contained to just these for now? |
|
I spoke with infi about this. Please put the constant definition in the packages/client/components/common/lib folder, and make sure you export it in the common package. Then update the icon reference on the sidebar and channel header as long as they are the same icon (if they aren't we will need to discuss further on it.) I would suggest creating a function that takes a channel and returns an icon string for that channel. |
Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
Dadadah
left a comment
There was a problem hiding this comment.
I like the solution using a context flag. Thanks. I'll have infi review this again.
Display the "headset_mic" icon for voice channel mentions, rather than the same "tag" - Makes it easier to distinguish channel types and provides a more friendly UI.
How was this PR tested?
Tested locally via typing the channel in text input, as well as after sent.
Screenshots & Screencasts (if appropriate)
Checklist:
Please declare, if any, LLM usage involved in creating this PR
None
...