Skip to content

feat: show headset mic for voice channel mentions#1251

Open
Asraye wants to merge 3 commits into
stoatchat:mainfrom
Asraye:feat/voice-channel-mentions
Open

feat: show headset mic for voice channel mentions#1251
Asraye wants to merge 3 commits into
stoatchat:mainfrom
Asraye:feat/voice-channel-mentions

Conversation

@Asraye

@Asraye Asraye commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Display the "headset_mic" icon for voice channel mentions, rather than the same "tag" - Makes it easier to distinguish channel types and provides a more friendly UI.

How was this PR tested?

Tested locally via typing the channel in text input, as well as after sent.

Screenshots & Screencasts (if appropriate)

image image

Checklist:

  • I have carefully read the contributing guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR
  • I have confirmed that any new dependencies are strictly necessary
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

Please declare, if any, LLM usage involved in creating this PR

None
...

Display the "headset_mic" icon for voice channel mentions, rather than the same "tag" - Makes it easier to distinguish channel types and provides a more friendly UI.

Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
@Asraye Asraye requested review from a team as code owners June 3, 2026 18:21
@Dadadah

Dadadah commented Jun 4, 2026

Copy link
Copy Markdown
Member

I think this needs UI/UX review

@infi infi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally icons per channel type should be centrally defined, hardcoding it in more places is not a good idea for long term maintenance ability. Merging this change as it is would make this harder however. Can this PR be expanded to define constants instead of hardcoded strings?

@Asraye

Asraye commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Ideally icons per channel type should be centrally defined, hardcoding it in more places is not a good idea for long term maintenance ability. Merging this change as it is would make this harder however. Can this PR be expanded to define constants instead of hardcoded strings?

@infi
Good point. Is there a preferred global constants file I should add these to, or should I create a new shared file somewhere for them?

Additionally; Do you want me to expand this PR beyond just the two files and add these constants into ServerSidebar & ChannelHeader? or, keep it contained to just these for now?

@Dadadah

Dadadah commented Jun 4, 2026

Copy link
Copy Markdown
Member

I spoke with infi about this.

Please put the constant definition in the packages/client/components/common/lib folder, and make sure you export it in the common package. Then update the icon reference on the sidebar and channel header as long as they are the same icon (if they aren't we will need to discuss further on it.) I would suggest creating a function that takes a channel and returns an icon string for that channel.

Asraye added 2 commits June 5, 2026 16:13
Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
@Asraye Asraye requested a review from infi June 5, 2026 06:18
@Asraye

Asraye commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@Dadadah @infi
Updated

PS: Added TEXT_SIDEBAR & TEXT_MENTION as they use slightly different icons for the # symbol (literally just different tilt), but If they're made to use the same one. It looks terrible!

@Dadadah Dadadah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solution using a context flag. Thanks. I'll have infi review this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants