add json inference model serialization#415
Open
sarptandoven wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the contribution @sarptandoven. The code seems correct but feels to me like this should be an issue we should handle with existing libraries as much as possible. I'm not sure if we need to be able to write to pure, "human-readable" json. So something like skops would likely be better and keep a smaller maintainable surface for ngboost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
save_ngboost_model_jsonandload_ngboost_model_jsonchange
k_categorical(K)NGBRegressorandNGBClassifierwhy
Fixes #392 by providing a portable JSON model artifact for inference instead of requiring pickle/joblib for fitted models.
scope
This is an inference serialization path for fitted NGBoost models using
DecisionTreeRegressorbase learners. It does not try to be a full training-resume checkpoint format.tests
poetry run pytest tests/test_pickling.py -qpoetry run pytest tests/test_basic.py -qpoetry run pytest tests/test_helpers.py tests/test_numpy2_compatibility.py tests/test_distns.py -qpoetry run pytest -qpoetry run pre-commit run --all-files