set classifier metadata#413
Open
sarptandoven wants to merge 2 commits into
Open
Conversation
alejandroschuler
approved these changes
Jun 24, 2026
Collaborator
|
Thanks for the update. #407 has now merged into Could you please rebase this branch onto latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
sets the sklearn classifier metadata that
NGBClassifierwas missing, so sklearn tooling can treat it as a classifier after fitting.fixes #350.
what changed
NGBClassifierinherit fromClassifierMixinclasses_duringfitand firstpartial_fitLabelEncoderpredictandstaged_predictback to the original labelsY_valwhen validation data is passedpredict_probaaligned withclasses_why
sklearn metrics/display helpers such as
RocCurveDisplay.from_estimatorandcross_val_score(..., scoring="roc_auc")expect fitted classifiers to expose classifier metadata, especiallyclasses_.without it,
NGBClassifiercan fit and predict, but fails in common sklearn evaluation paths.validation
git diff --checkmake lintpartial_fit, multiclass labels, clone, and pickle round-trippytest tests/test_basic.py::test_classifier_sets_sklearn_classes_and_encodes_labels -qpytest tests/test_basic.py -qpytest -qmake test