Handle CronJob upgrade via active Job Pod deletion

[trvrnrth]

Instead of immediately creating new Jobs we will instead delete pods belonging to active Jobs. This will cause the job controller to re-create the pods based on the defined policies.

As such we will not violate the CronJob schedule, suspension and concurrency policies.

Resolves #822

[Copilot]

Pull request overview

Resolves the dangerous behavior in which Reloader would create new Job instances from a (potentially suspended) CronJob when an associated ConfigMap/Secret changed. Instead, the CronJob UpdateFunc now deletes the running pods of currently active Jobs, allowing the Job controller to recreate them per the configured policies and respecting CronJob suspension/concurrency.

Changes:

• Replace CreateJobFromCronjob with RestartRunningCronjobPods, which deletes pods of cronJob.Status.Active jobs via Pods.DeleteCollection filtered by JobNameLabel and status.phase=Running.
• Add pods: deletecollection RBAC to both the static manifest and the Helm chart (gated by ignoreCronJobs && ignoreJobs).
• Update tests with a fake-client reactor for delete-collection on pods, plus various doc-comment typo fixes.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
internal/pkg/callbacks/rolling_upgrade.go	Replace job-creation logic with pod deletion of active CronJob jobs; fix doc comment.
internal/pkg/callbacks/rolling_upgrade_test.go	Rewrite test to verify only running pods of active jobs are deleted; add fake reactor and helpers.
internal/pkg/handler/upgrade.go	Wire CronJob UpdateFunc to new RestartRunningCronjobPods; fix doc comments.
internal/pkg/testutil/kube.go	Doc-comment typo fixes.
pkg/kube/client.go	Doc-comment typo fix.
deployments/kubernetes/manifests/clusterrole.yaml	Add pods: deletecollection permission.
deployments/kubernetes/chart/reloader/templates/clusterrole.yaml	Conditionally add pods: deletecollection permission.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.