Added spec.podTemplateSpec support to MCPRemoteProxy#5531
Open
Sanskarzz wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5531 +/- ##
==========================================
- Coverage 69.75% 69.75% -0.01%
==========================================
Files 646 646
Lines 65697 65824 +127
==========================================
+ Hits 45830 45915 +85
- Misses 16522 16547 +25
- Partials 3345 3362 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
03b0a06 to
9365a26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
spec.podTemplateSpecsupport toMCPRemoteProxyso remote proxy workloads can be customized like the other ToolHive workload CRDs.Although the issue calls out
v1alpha1, this branch definesv1alpha1.MCPRemoteProxy.Specasv1beta1.MCPRemoteProxySpec, so the API field is added to the sharedv1beta1spec. Regenerated CRDs expose the field in both served schema sections.Fixes #4549
Type of change
Test plan
task test)task test-e2e)task lint-fix)API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Changes
spec.podTemplateSpectoMCPRemoteProxySpecusingruntime.RawExtensionwith unknown-field preservation.PodTemplateValidcondition type and valid/invalid reasons.controllerutil.ApplyPodTemplateSpecPatchstrategic merge helper.toolhive.stacklok.io/podtemplatespec-hashannotation.