Skip to content

quickfix to adopt ApplicationModuleListener #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoddyN wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

quickfix to adopt ApplicationModuleListener #1904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...boot-language-server/src/main/java/org/springframework/ide/vscode/boot/app/JdtConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.springframework.ide.vscode.boot.java.data.jpa.queries.JpqlSupportState;
import org.springframework.ide.vscode.boot.java.data.jpa.queries.QueryJdtAstReconciler;
import org.springframework.ide.vscode.boot.java.handlers.Reconciler;
import org.springframework.ide.vscode.boot.java.reconcilers.ApplicationModuleListenerReconciler;
import org.springframework.ide.vscode.boot.java.reconcilers.AddConfigurationIfBeansPresentReconciler;
import org.springframework.ide.vscode.boot.java.reconcilers.AuthorizeHttpRequestsReconciler;
import org.springframework.ide.vscode.boot.java.reconcilers.AutowiredFieldIntoConstructorParameterReconciler;
Expand Down Expand Up @@ -152,6 +153,10 @@ public class JdtConfig {
@Bean ModulithTypeReferenceViolationReconciler modulithTypeReferenceViolationReconciler() {
return new ModulithTypeReferenceViolationReconciler();
}

@Bean ApplicationModuleListenerReconciler applicationModuleListenerReconciler(SimpleLanguageServer server) {
return new ApplicationModuleListenerReconciler(server.getQuickfixRegistry());
}

@Bean NoRepoAnnotationReconciler noRepoAnnotationReconciler(SimpleLanguageServer server) {
return new NoRepoAnnotationReconciler(server.getQuickfixRegistry());
Expand Down
8 changes: 8 additions & 0 deletions ...t-language-server/src/main/java/org/springframework/ide/vscode/boot/java/Annotations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ public class Annotations {

public static final String CONTEXT_CONFIGURATION = "org.springframework.test.context.ContextConfiguration";
public static final String SCHEDULED = "org.springframework.scheduling.annotation.Scheduled";
public static final String ASYNC = "org.springframework.scheduling.annotation.Async";

public static final String TRANSACTIONAL = "org.springframework.transaction.annotation.Transactional";
public static final String TRANSACTIONAL_EVENT_LISTENER = "org.springframework.transaction.event.TransactionalEventListener";

// Modulith

public static final String APPLICATION_MODULE_LISTENER = "org.springframework.modulith.events.ApplicationModuleListener";

// Beans

Expand Down
6 changes: 5 additions & 1 deletion ...e-server/src/main/java/org/springframework/ide/vscode/boot/java/Boot3JavaProblemType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
package org.springframework.ide.vscode.boot.java;

import static org.springframework.ide.vscode.commons.languageserver.reconcile.ProblemSeverity.ERROR;
import static org.springframework.ide.vscode.commons.languageserver.reconcile.ProblemSeverity.WARNING;

import java.util.List;

Expand All @@ -28,7 +29,10 @@ public enum Boot3JavaProblemType implements ProblemType {

JAVA_TYPE_NOT_SUPPORTED(ERROR, "Type no supported as of Spring Boot 3", "Type not supported as of Spring Boot 3"),
FACTORIES_KEY_NOT_SUPPORTED(ERROR, "Spring factories key not supported", "Spring factories key not supported"),
MODULITH_TYPE_REF_VIOLATION(ERROR, "Modulith restricted type reference", "Modulith restricted type reference");
MODULITH_TYPE_REF_VIOLATION(ERROR, "Modulith restricted type reference", "Modulith restricted type reference"),
MODULITH_APPLICATION_MODULE_LISTENER(WARNING,
"Prefer @ApplicationModuleListener over @Async + @Transactional + @TransactionalEventListener",
"Use @ApplicationModuleListener");

private final ProblemSeverity defaultSeverity;
private final String description;
Expand Down