[P4Orch] Add label to uniquely identify udf group object. - #4211
Draft
ksravani-hcl wants to merge 1 commit into
Draft
[P4Orch] Add label to uniquely identify udf group object.#4211ksravani-hcl wants to merge 1 commit into
ksravani-hcl wants to merge 1 commit into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mint570
previously approved these changes
Mar 12, 2026
ksravani-hcl
force-pushed
the
acl_rule_s1
branch
from
March 26, 2026 05:20
6d010f3 to
85e110c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ksravani-hcl
force-pushed
the
acl_rule_s1
branch
from
April 6, 2026 07:24
85e110c to
62eae76
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mint570
approved these changes
Apr 14, 2026
ksravani-hcl
changed the title
mint570
previously approved these changes
Apr 17, 2026
Contributor
|
@prsunny can you take a look at this PR to see how this can impact upstream SONiC? |
ksravani-hcl
marked this pull request as ready for review
April 24, 2026 14:29
Contributor
ksravani-hcl
force-pushed
the
acl_rule_s1
branch
from
April 28, 2026 10:10
62eae76 to
5e182ac
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ksravani-hcl
force-pushed
the
acl_rule_s1
branch
from
April 28, 2026 10:16
5e182ac to
7d23464
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mint570
previously approved these changes
Apr 30, 2026
Collaborator
|
Same comments for namelabel as other PRs. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ksravani-hcl
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ksravani-hcl
marked this pull request as draft
May 15, 2026 12:08
ksravani-hcl
force-pushed
the
acl_rule_s1
branch
from
July 24, 2026 03:55
2fbe534 to
aa93c32
Compare
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
ksravani-hcl
force-pushed
the
acl_rule_s1
branch
from
August 14, 2026 13:53
aa93c32 to
d925941
Compare
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Adding label to uniquely identify udf group object.
Introduced a NameLabelMapper utility to manage unique object-to-label mappings and integrated it into the OrchDaemon lifecycle. Modified p4orch to assign a persistent SAI_UDF_GROUP_ATTR_LABEL during UDF group creation and implemented STATE_DB serialization to preserve these mappings across warm restarts.
Why I did it
To standardize the identification of SAI objects that lack a primary unique key, such as UDF groups, to enable accurate object correlation during reconciliation. This ensures hitless warm restarts and prevents duplicate hardware object creation by providing a persistent identifier that survives control plane restarts.
How I verified it
Verified the persistence mechanism through local builds and successful execution of the full unit test suite.
Details if related
#4176 is the base PR for #4211 & #4246.