Skip to content

fix(import): gracefully handle orphaned client references in Toggl importer #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidLambauer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(import): gracefully handle orphaned client references in Toggl importer #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/Service/Import/Importers/TogglDataImporter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,11 @@ public function importData(string $data, string $timezone): void
if ($project->client_id !== null) {
$clientId = $this->clientImportHelper->getKeyByExternalIdentifier((string) $project->client_id);
if ($clientId === null) {
throw new Exception('Client does not exist');
// Client was deleted in Toggl but still referenced by a project — skip gracefully
Log::warning('TogglDataImporter: Project references a non-existent client, importing without client', [
'project_name' => $project->name,
'client_id' => $project->client_id,
]);
}
}

Expand Down