Skip to content

Use unique file names for temporary files fix flaky tests #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Greenheart wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Use unique file names for temporary files fix flaky tests #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/toFile.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ test('toFile svg', function (t) {
})

test('toFile utf8', function (t) {
const fileName = path.join(os.tmpdir(), 'qrimage.txt')
const fileName = path.join(os.tmpdir(), 'qrimage-utf8.txt')
const expectedOutput = [
' ',
' ',
Expand Down Expand Up @@ -225,7 +225,7 @@ test('toFile utf8', function (t) {
})

test('toFile manual segments', function (t) {
const fileName = path.join(os.tmpdir(), 'qrimage.txt')
const fileName = path.join(os.tmpdir(), 'qrimage-segments.txt')
const segs = [
{ data: 'ABCDEFG', mode: 'alphanumeric' },
{ data: '0123456', mode: 'numeric' }
Expand Down
2 changes: 1 addition & 1 deletion test/unit/renderer/utf8.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ test('Utf8Renderer render', function (t) {

test('Utf8 renderToFile', function (t) {
const sampleQrData = QRCode.create('sample text', { version: 2 })
const fileName = 'qrimage.txt'
const fileName = 'qrimage-to-file.txt'
let fsStub = sinon.stub(fs, 'writeFile').callsArg(2)

t.plan(5)
Expand Down