Skip to content

Redis代理连接执行unlink方法传参丢失#564

Merged
nobodyiam merged 2 commits into
sofastack:masterfrom
gitYupan:master
Jun 7, 2026
Merged

Redis代理连接执行unlink方法传参丢失#564
nobodyiam merged 2 commits into
sofastack:masterfrom
gitYupan:master

Conversation

@gitYupan
Copy link
Copy Markdown
Contributor

TracingRedisConnection在代理unlink命令时没有将参数参入被代理的连接中

Copy link
Copy Markdown
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 这次改动修复了 Redis varargs 方法通过代理调用时参数没有传给底层 connection 的问题。

我确认过当前实现会把 existsunlinktouchkeys 显式传入底层 Redis connection;同类的 TracingRedisConnection varargs method reference 也没有看到遗漏。本地跑过:

mvn -pl sofa-tracer-plugins/sofa-tracer-redis-plugin -am -DskipTests compile

已通过。GitHub 上 buildsofastack-bot/cla 也都通过。

@nobodyiam nobodyiam merged commit 63a37a7 into sofastack:master Jun 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants