Redis代理连接执行unlink方法传参丢失#564
Merged
Merged
Conversation
Redis代理连接执行unlink方法传参丢失
nobodyiam
approved these changes
May 16, 2026
Member
nobodyiam
left a comment
There was a problem hiding this comment.
LGTM. 这次改动修复了 Redis varargs 方法通过代理调用时参数没有传给底层 connection 的问题。
我确认过当前实现会把 exists、unlink、touch 的 keys 显式传入底层 Redis connection;同类的 TracingRedisConnection varargs method reference 也没有看到遗漏。本地跑过:
mvn -pl sofa-tracer-plugins/sofa-tracer-redis-plugin -am -DskipTests compile
已通过。GitHub 上 build 和 sofastack-bot/cla 也都通过。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TracingRedisConnection在代理unlink命令时没有将参数参入被代理的连接中