fix(athena): support WIF/IRSA auth by making static credentials optional#2735
Open
nielsn wants to merge 1 commit into
Open
fix(athena): support WIF/IRSA auth by making static credentials optional#2735nielsn wants to merge 1 commit into
nielsn wants to merge 1 commit into
Conversation
V4's pydantic model marked access_key_id/secret_access_key as required, breaking the V3 behavior where omitting them lets the AWS SDK use its default credential provider chain (IAM Roles for Service Accounts / web identity federation). Make both optional, guard secret unwrapping, and require them both-or-neither. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Niels-b
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Customers (Alpiq, FirstStudent, Fitch) need WIF / IRSA auth for Athena — AWS issues short-lived tokens automatically, so no static access keys should be passed. V3 supported this implicitly (untyped config →
Noneflows intopyathena.connect()). V4's pydantic model markedaccess_key_id/secret_access_keyas required, so omitting them raises aValidationErrorbefore any connection attempt, blocking onboarding.What
access_key_id/secret_access_key→Optional(defaultNone).region_nameandstaging_dirstay required.secret_access_key.get_secret_value()againstNone.Tests
partial_credentials: asserts the both-or-neither error.test_athena_connection_without_static_credentials_parses: parse-only regression test proving creds can be omitted (no live AWS needed).Scope
Connector side only. The webapp/onboarding UI has its own PR: https://github.com/sodadata/soda/pull/12348