return None for identities in FIPS environments where blake2b is unavailable#2717
Open
bujjibabukatta wants to merge 3 commits into
Open
return None for identities in FIPS environments where blake2b is unavailable#2717bujjibabukatta wants to merge 3 commits into
bujjibabukatta wants to merge 3 commits into
Conversation
added 2 commits
May 19, 2026 16:43
…to 'soda contract verify' that prints all SQL queries that would be executed without running them against the data source. Useful for cost estimation before running expensive queries (e.g. BigQuery charges per byte scanned). When --dry-run is passed: - Queries are built but not executed - Each SQL query is logged with a [DRY RUN] prefix - Check results are not evaluated (NOT_EVALUATED) Fixes sodadata#2473
|
bujjibabukatta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
for more information, see https://pre-commit.ci
|
Author
|
Hi @CLAassistant can you please approve and merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2354
Problem
In FIPS 140-2 compliant environments (government/finance hardened Linux),
hashlib.blake2bis disabled at the OS level causingImportErroratstartup, making Soda Core completely unusable in these environments.
Approach
Following the maintainer's agreed direction in #2354 — rather than
falling back to a different hash algorithm (which would make identities
environment-dependent), return
Nonewhenblake2bis unavailable.Identities are only meaningful for Soda Cloud users. Returning
Noneis safe and honest for soda-core-only users in FIPS environments.
Changes
Single file change in
consistent_hash_builder.py:blake2bimport intry/except ImportErrorblake2bcalls — skip hashing when unavailableget_hash()already returnsNonewhen nothing was hashed — no change neededTesting
To verify: run in a FIPS-enabled environment or mock the ImportError by
temporarily removing the
blake2bimport.get_hash()should returnNone.