feat: add mysql test dispatch#2687
Draft
paulteehan wants to merge 1 commit into
Draft
Conversation
Wires the test framework dispatch for the MySQL v4 adapter (soda-mysql, landing in soda-extensions). Companion change to feature/mysql-support in soda-extensions and soda-library. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the test framework dispatch for the MySQL v4 adapter (soda-mysql, landing in soda-extensions). Adds a single
elif test_datasource == "mysql"branch indata_source_test_helper.pythat importsMySqlDataSourceTestHelperfrom the new soda-extensions package.This is the smallest of three companion PRs — merge order is soda-core first, then soda-extensions, then soda-library. All three branches share the name
feature/mysql-supportso the CI cross-resolution works.Companion PRs
feature/mysql-support— the v4soda-mysql/adapter package, dialect, DWH extension, CI workflow updates.feature/mysql-support— modernized v3 adapter (driver swap from mysql-connector-python to PyMySQL for license correctness; bug fixes; v4 bridge factory).Test plan
mysqlmatrix entry uses this dispatch.soda-tests/tests/integration/test_conformance_*.pyruns againstTEST_DATASOURCE=mysqlafter the soda-extensions PR is merged.🤖 Generated with Claude Code