Skip to content

fix: override supports_regex_advanced to False in RedshiftDataSource (#2269) #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devimano2011 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: override supports_regex_advanced to False in RedshiftDataSource (#2269) #2674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions soda-redshift/src/soda_redshift/common/data_sources/redshift_data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,5 +205,16 @@ def table_columns(self) -> str:
def build_columns_metadata_from_clause(self, table_namespace: DataSourceNamespace) -> FROM:
return FROM(self.table_columns()).IN(self._pg_catalog_schema())

def supports_regex_advanced(self) -> bool:
"""
Redshift uses POSIX regex (~ operator) which does NOT support advanced
regex features like lookaheads/lookbehinds (e.g., (?!...), (?=...)).
Returning False signals soda-core to raise InvalidRegexException
rather than generating a query that Redshift will reject.
Fixes: https://github.com/sodadata/soda-core/issues/2269
"""
return False


def _pg_catalog_schema(self) -> str:
return "pg_catalog"