feat: default check names for llm, hierarchy, and fuzzy_duplicate check types#2613
Draft
LaurenDebruyn wants to merge 2 commits into
Draft
feat: default check names for llm, hierarchy, and fuzzy_duplicate check types#2613LaurenDebruyn wants to merge 2 commits into
LaurenDebruyn wants to merge 2 commits into
Conversation
LaurenDebruyn
changed the title
LaurenDebruyn
force-pushed
the
feat/llm-checks-and-remediation
branch
from
3a8e2b5 to
e424ecb
Compare
|
LaurenDebruyn
force-pushed
the
feat/llm-checks-and-remediation
branch
from
e424ecb to
d3f4026
Compare
LaurenDebruyn
force-pushed
the
feat/llm-checks-and-remediation
branch
from
d3f4026 to
703c5c3
Compare
LaurenDebruyn
force-pushed
the
feat/llm-checks-and-remediation
branch
from
703c5c3 to
101ebe9
Compare
|
Without this, fuzzy_duplicate checks with no explicit `name:` in the contract fall through to using the raw type name "fuzzy_duplicate" as the check_name written to the DW, instead of the human-readable "No fuzzy duplicate values". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
LaurenDebruyn
force-pushed
the
feat/llm-checks-and-remediation
branch
from
101ebe9 to
57982c5
Compare
|
LaurenDebruyn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds default human-readable check names in
CheckImpl.DEFAULT_NAMESfor three new check types implemented in soda-extensions:llm→ "LLM validation passes"hierarchy→ "Hierarchy structure is valid"fuzzy_duplicate→ "No fuzzy duplicate values"Without these, checks with no explicit
name:in the contract fall through to the raw type string (e.g."fuzzy_duplicate") as thecheck_namewritten to the diagnostics warehouse, instead of the readable label.Companion PRs (soda-extensions)
feat: add soda-llm package with tools framework and reference lookupsfeat: add soda-hierarchy package for hierarchical data quality checksfeat: add soda-fuzzy-duplicate extensionTest plan
llm,hierarchy, andfuzzy_duplicatechecks withoutname:emit the readable default to the DW🤖 Generated with Claude Code