Improve memory efficiency Particle class - #397
Merged
Merged
Conversation
Collaborator
Author
|
The missing CHANGELOG entry is in PR #398 with a new section for the next version. I didn't add it here to avoid conflicts. |
RenataKrupczak
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the memory efficiency on the Particle class level. This is critical in analyses where many events are used. I ran into this trap recently. The Particle class was always using a static array of 25 entries for the properties. Now the memory is dynamically added with an index map which is more memory efficient, even in the dense Oscar2013Extended format.
This is a benchmark run after the current implementation:
Compared to the issue #396 benchmark run, this is an improvement of ~42% for the JETSCAPE format and 13% for the Oscar2013Extended format.
This closes #396.
I just add all of you to this PR. I don't know who has time to review at the moment.