Skip to content

[Gear] Trinket - Fang of Umbral Malignance #11534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
criller7070 wants to merge 4 commits into
base: midnight
Choose a base branch
from
+48 −0
Open

[Gear] Trinket - Fang of Umbral Malignance #11534

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f126c60
[Gear] Trinket - Fang of Umbral Malignance
criller7070 Jun 23, 2026
c13bc36
trinket now works on ptr
criller7070 Jun 25, 2026
9a3caf1
removed extra debuff
criller7070 Jun 25, 2026
846822f
Merge branch 'midnight' into fang-of-umbral-malignance_implementation
criller7070 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions engine/player/unique_gear_midnight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3134,7 +3134,57 @@ void vile_vial_of_volatile_venom( special_effect_t& effect )
effect.disable_buff();
effect.has_use_buff_override = true;
effect.execute_action = create_proc_action<vile_vial_of_volatile_venom_t>( "empowering_venom", effect );
}

// Fang of Umbral Malignance
// 1295219 Driver
// 1305853 Umbral Malignance DoT
// 1305854 Bursting Malignance AoE
void fang_of_umbral_malignance( special_effect_t& effect )
{
auto burst = create_proc_action<generic_aoe_proc_t>( "bursting_malignance", effect, 1305854 );
burst->base_multiplier *= role_mult( effect );

struct fang_cb_t : public dbc_proc_callback_t
{
action_t* dot;

fang_cb_t( const special_effect_t& e, action_t* burst_action ) : dbc_proc_callback_t( e.player, e )
{
dot = create_proc_action<generic_proc_t>( "umbral_malignance", e, 1305853 );
dot->dot_max_stack = dot->data().max_stacks();
dot->base_td = e.driver()->effectN( 1 ).average( e );
dot->base_td_multiplier *= role_mult( e );
dot->add_child( burst_action );
target_debuff = e.player->find_spell( 1305853 );

@nyterage nyterage Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see any reason why you'd need the debuff here? the DoT already handles everything? i dont see it being used for anything here

@criller7070 criller7070 Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intention was to make the log clearer in showing the debuff stacks.

@nyterage nyterage Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the DoT already has the stack data. Shouldn't need to add an extra debuff to get stack data from that. having a secondary stacking effect being created on every target is also a performance concern when dot/debuff data is lazily initialized, only created when its first applied, basically costing 2x the initialization for every target its ever applied to during runtime.

}

void execute( const spell_data_t*, player_t* t, action_state_t* ) override
{
dot->execute_on_target( t );
get_debuff( t )->trigger();
}
};

auto cb = new fang_cb_t( effect, burst );
auto burst_pct = effect.driver()->effectN( 2 ).percent();

effect.player->register_on_kill_callback( [ cb, burst, burst_pct ]( player_t* t ) {
if ( t->sim->event_mgr.canceled )
return;

if ( auto d = cb->dot->find_dot( t ); d && d->is_ticking() )
{
burst->base_dd_min = burst->base_dd_max = d->tick_damage_over_remaining_time() * burst_pct;
burst->execute();

for ( auto new_target : cb->dot->target_list() )
{
cb->dot->execute_on_target( new_target );
cb->get_debuff( new_target )->trigger();
}
}
} );
}
} // namespace trinkets

Expand Down Expand Up @@ -4177,6 +4227,7 @@ void register_special_effects()
register_special_effect( 1295058, trinkets::wavecallers_seastone );
register_special_effect( 1293316, trinkets::vile_vial_of_volatile_venom );
register_special_effect( 1295179, DISABLED_EFFECT ); // Vile Vial of Volatile Venom equip driver
register_special_effect( 1295219, trinkets::fang_of_umbral_malignance );
reset_version_check();
// Weapons
register_special_effect( { 1253357, 1253359 }, weapons::torments_duality ); // umbral sabre & radiant foil
Expand Down
Loading