Fix --xl -r extracting code from oldest response instead of most recent#1524
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix --xl -r extracting code from oldest response instead of most recent#1524ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
4eee400 to
1b9038d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a conversation has multiple responses and you run
llm logs --xl -r, the extracted code block comes from the oldest response in the conversation rather than the most recent one. This happens because the extract loop iteratesrowsfrom the start (oldest after the DESC-then-reverse ordering), while-rcorrectly reads fromrows[-1](newest). The fix restricts the search torows[-1]when-ris active, so both flags operate on the same response. Fixes #821.