Fix embed/embed_multi not updating content column when store=True re-run#1516
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix embed/embed_multi not updating content column when store=True re-run#1516ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
…t was previously NULL When content is re-embedded with --store after an initial run without --store, the content_hash match caused an early return without populating the content column. Now checks if the existing record has NULL content and updates it. Fixes simonw#224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you first run embed or embed_multi without --store, then re-run with --store, the content column stays NULL because the content_hash match causes an early return. This makes it impossible to add content storage to an existing collection without deleting and recreating it.
The fix checks whether the existing record already has content populated, and if not, updates it in place without re-computing the embedding.
Fixes #224