Preserve streaming timings from OpenAI-compatible providers.#1507
Open
dmsnell wants to merge 1 commit into
Open
Preserve streaming timings from OpenAI-compatible providers.#1507dmsnell wants to merge 1 commit into
dmsnell wants to merge 1 commit into
Conversation
llama.cpp's OpenAI-compatible streaming endpoint can include token/sec metrics in a top-level `timings` field on the final streamed chunk. `llm` was already preserving usage from that chunk, but `combine_chunks()` discarded provider-specific timing metadata, so `llm logs --json` could not show the throughput data even when the provider returned it. In this patch, `timings` is captured while combining streamed chunks and include it in the persisted response JSON. Add a regression test using a llama.cpp-style streaming response. Co-Authored-By: Codex (GPT-5.5)
Author
|
I’ve seen this before, where This returns the API timing information into the logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llama.cpp's OpenAI-compatible streaming endpoint can include token/sec metrics in a top-level
timingsfield on the final streamed chunk.llmwas already preserving usage from that chunk, butcombine_chunks()discarded provider-specific timing metadata, sollm logs --jsoncould not show the throughput data even when the provider returned it.In this patch,
timingsis captured while combining streamed chunks and include it in the persisted response JSON. Add a regression test using a llama.cpp-style streaming response.Co-Authored-By: Codex (GPT-5.5)