Account for tube orientation in det match#1627
Open
mmccrackan wants to merge 17 commits into
Open
Conversation
Member
|
The unit test failures here are due to an interplay between the latest toast wheels and the so3g wheels. I'm debugging in a separate PR. |
added 2 commits
June 1, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for #1603 into det match to properly account for ASO tube orientation.
Adds matching support for LF wafers all at once. If input wafer is
ws., it will first check the imprinter file and find thewafersandwafer_slots. It will then get thewafer_infofor each of those wafers, selectdet_id'sthat are for the correct wafer, store these as a list, then merge all of them at the end. The loads the fullwafer_infoand puts thexi,eta, andwafer_slotfields in the correct rows to maintain thedet_idorder (order is important) Also addsignore_north_southoption since this is not relevant for LF.Removed the book check for
wafer_slotas the field is now in the axis managers anyway. Defaults tows.since that was chosen for LF for when we don't know the wafer.Now populates
wafer_slotto thedet_matchmetadata since this will likely be needed downstream.Updated optics zemax file reading to work with the new file that was produced to fix the edge effects on o6.