Skip to content

Account for tube orientation in det match#1627

Open
mmccrackan wants to merge 17 commits into
masterfrom
260426_aso
Open

Account for tube orientation in det match#1627
mmccrackan wants to merge 17 commits into
masterfrom
260426_aso

Conversation

@mmccrackan

@mmccrackan mmccrackan commented May 1, 2026

Copy link
Copy Markdown
Contributor

Adds support for #1603 into det match to properly account for ASO tube orientation.

Adds matching support for LF wafers all at once. If input wafer is ws., it will first check the imprinter file and find the wafers and wafer_slots. It will then get the wafer_info for each of those wafers, select det_id's that are for the correct wafer, store these as a list, then merge all of them at the end. The loads the full wafer_info and puts the xi, eta, and wafer_slot fields in the correct rows to maintain the det_id order (order is important) Also adds ignore_north_south option since this is not relevant for LF.

Removed the book check for wafer_slot as the field is now in the axis managers anyway. Defaults to ws. since that was chosen for LF for when we don't know the wafer.

Now populates wafer_slot to the det_match metadata since this will likely be needed downstream.

Updated optics zemax file reading to work with the new file that was produced to fix the edge effects on o6.

@tskisner

tskisner commented May 5, 2026

Copy link
Copy Markdown
Member

The unit test failures here are due to an interplay between the latest toast wheels and the so3g wheels. I'm debugging in a separate PR.

@mmccrackan mmccrackan marked this pull request as ready for review June 1, 2026 15:25
@mmccrackan mmccrackan requested a review from mhasself June 1, 2026 15:26
Michael McCrackan added 2 commits June 1, 2026 08:50
@mmccrackan mmccrackan marked this pull request as draft June 1, 2026 17:42
@mmccrackan mmccrackan marked this pull request as ready for review June 1, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants