Skip to content

monitoring: make workloads dashboard plan idempotent #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ejahnGithub wants to merge 5 commits into
base: main
Choose a base branch
from
Open

monitoring: make workloads dashboard plan idempotent #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df09feb
monitoring: make workloads dashboard plan idempotent
ejahnGithub Jun 8, 2026
402f72c
TEMP: tweak workloads dashboard displayName to verify plan
ejahnGithub Jun 9, 2026
22921bf
TEMP: tweak spanner dashboard displayName in tf to verify plan
ejahnGithub Jun 9, 2026
67d661f
Revert TEMP displayName change in workloads.json
ejahnGithub Jun 9, 2026
7666c06
Revert plan-verification label; keep minor displayName tweak
ejahnGithub Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gcp/modules/monitoring/infra/dashboards.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
resource "google_monitoring_dashboard" "spanner_cpu_dashboard" {
dashboard_json = <<EOF
{
"displayName": "Spanner CPU Alerts",
"displayName": "Spanner CPU Alerts.",

@cmurphy cmurphy Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to change this, I think Hayden meant something else when he asked for a temporary change.

"mosaicLayout": {
"columns": 48,
"tiles": [
Expand Down
9 changes: 0 additions & 9 deletions gcp/modules/monitoring/infra/workloads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"columns": 12,
"tiles": [
{
"xPos": 0,
"yPos": 0,
"width": 12,
"height": 4,
"widget": {
Expand All @@ -21,7 +19,6 @@
}
},
{
"xPos": 0,
"yPos": 4,
"width": 6,
"height": 4,
Expand Down Expand Up @@ -95,7 +92,6 @@
}
},
{
"xPos": 0,
"yPos": 8,
"width": 6,
"height": 4,
Expand Down Expand Up @@ -185,7 +181,6 @@
}
},
{
"xPos": 0,
"yPos": 12,
"width": 6,
"height": 4,
Expand Down Expand Up @@ -259,7 +254,6 @@
}
},
{
"xPos": 0,
"yPos": 16,
"width": 6,
"height": 4,
Expand Down Expand Up @@ -336,7 +330,6 @@
}
},
{
"xPos": 0,
"yPos": 20,
"width": 6,
"height": 4,
Expand Down Expand Up @@ -414,7 +407,6 @@
}
},
{
"xPos": 0,
"yPos": 24,
"width": 6,
"height": 4,
Expand Down Expand Up @@ -486,7 +478,6 @@
}
},
{
"xPos": 0,
"yPos": 28,
"width": 12,
"height": 4,
Expand Down