Skip to content

Update jsonscheme2dataclass plugin to 6.0.0#305

Open
loosebazooka wants to merge 1 commit into
mainfrom
update-js2dc
Open

Update jsonscheme2dataclass plugin to 6.0.0#305
loosebazooka wants to merge 1 commit into
mainfrom
update-js2dc

Conversation

@loosebazooka

Copy link
Copy Markdown
Member

Signed-off-by: Appu Goundan appu@google.com

Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka loosebazooka requested a review from vlsi January 14, 2023 18:10
@loosebazooka loosebazooka added the safe to test conformance testing label label Jan 14, 2023
@vlsi

vlsi commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

For reference, the failure is caused by empty @param data javadocs generated on constructors as follows: joelittlejohn/jsonschema2pojo#1463

    /**
     * 
     * @param data
     * @param signature
     */
    public HashedRekord(Signature signature, Data data) {
        super();
        this.signature = signature;
        this.data = data;
    }

@loosebazooka

Copy link
Copy Markdown
Member Author

I think I'm going to ignore the javadoc generation on this subpath for now.

@loosebazooka

Copy link
Copy Markdown
Member Author

javadoc is really annoying to configure. Might sit on this for a while. Another option is change the package of the generated model from dev.sigstore.rekor -> dev.sigstore.rekor.model and exclude just that package path (easy)

@vlsi

vlsi commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

@loosebazooka , another idea: add regexp-based processing to kill ill javadocs or replace them with @param data data.

WDYT?

@vlsi

vlsi commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

Using a separate package for generated code looks good to me.

@loosebazooka

Copy link
Copy Markdown
Member Author

@loosebazooka , another idea: add regexp-based processing to kill ill javadocs or replace them with @param data data.

Hah, I think I would rather not do this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test conformance testing label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants