fix: copy shortcut must not swallow the page's default copy#132
Merged
Conversation
|
🎉 This PR is included in version 2.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The document-level Cmd/Ctrl+C handler called preventDefault before checking whether a clip was selected, so while the editor is mounted, host-app text outside editable fields could never be copied. With a clip selected, clip copy also shadowed an active text selection.
Copy is now only intercepted when it will act on a clip: with no selected clip, or with a non-collapsed text selection anywhere in the document, the browser's default copy runs. Because pointer-down on the canvas or timeline natively collapses any existing text selection, selecting a clip always clears stale text selections first — so clip copy behaves exactly as before whenever the user's most recent action was selecting a clip, and a fresh text selection wins otherwise.
Paste interception is unchanged: outside editable fields there is no observable default paste, and editable fields are already exempt.
Verified with 4 new jsdom tests (no clip, clip copy, text selection wins, editable-field exemption); full suite of 1813 tests passes.