Skip to content

Added a feature so right clicking an audio icon pops up the audio mixer#58

Open
oliviermilla wants to merge 2 commits into
sejjy:mainfrom
oliviermilla:main
Open

Added a feature so right clicking an audio icon pops up the audio mixer#58
oliviermilla wants to merge 2 commits into
sejjy:mainfrom
oliviermilla:main

Conversation

@oliviermilla
Copy link
Copy Markdown

When right clicking an audio icon in machabar, either wiremix or pavucontrol is launched.
This is super convenient to rapidly access the audio mixer straight from the bar.

I've chosen wiremix as the default app to remain consistent with the TUI spirit from bluetooth & other icons's behaviors.

Current behavior is untouched: when clicking an icon, this will turn either input or output off though I'd say the opposite makes more sense to the user:

  • left click => mixer
  • right click => mute

and is more consistent with other icons such as bluetooth where right click turns the protocol off.

@sejjy
Copy link
Copy Markdown
Owner

sejjy commented May 5, 2026

Hi,

These new features are interesting, but I’d prefer to keep the default config as simple as it is right now.

There have been many changes in this repo, mainly because I wanted to keep only what's needed out of the box. These include removing indirect dependencies and unnecessary files.

Regarding the behavior of the volume module, I set on-click to toggle device mute since it's the primary action, similar to how clicking the idle_inhibitor module toggles its state.

@sejjy
Copy link
Copy Markdown
Owner

sejjy commented May 5, 2026

Now that I think about it, it might make sense to swap the on-click and on-click-right actions of the bluetooth and network modules for consistency, so toggling state becomes the primary action.

@sejjy
Copy link
Copy Markdown
Owner

sejjy commented May 5, 2026

But that would leave the custom/update module different from the two, since it would be the only one where left-click launches a CLI. Swapping its on-click and on-click-right doesn't make sense as refreshing the module wouldn't be a good primary action.

@sejjy
Copy link
Copy Markdown
Owner

sejjy commented May 5, 2026

You can ignore my previous two replies. Sorry about that.

@oliviermilla
Copy link
Copy Markdown
Author

Yeah I'd make the left/right click consistent.
Regarding custom/update, having left (or both left & right) trigger the CLI makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants