Skip to content

Improvements to system-update.sh#54

Open
oliviermilla wants to merge 2 commits into
sejjy:fix/v0.14.0from
oliviermilla:useparu
Open

Improvements to system-update.sh#54
oliviermilla wants to merge 2 commits into
sejjy:fix/v0.14.0from
oliviermilla:useparu

Conversation

@oliviermilla
Copy link
Copy Markdown

@oliviermilla oliviermilla commented Apr 3, 2026

Hello,

This fix contains two improvements :

  1. Removed the dependency call to checkupdates if you are using a helper (paru, etc.). (Install script not modified though)
  2. Filter the updates concerning an package which version is pinned (using downgrade cmd: https://archlinux-downgrade.github.io/downgrade/)

- Use AUR helper (-Qud/-Qua) for update checking when available
- Fall back to checkupdates only when no helper is found (AUR_UPD=0)
- Simplify update_packages() to use helper or pacman exclusively
- Update header comments and README with helper documentation
- Add set -o pipefail to capture helper exit status through pipelines
- Add get_ignored_pkgs() to parse IgnorePkg from /etc/pacman.conf
- Add filter_ignored() to exclude ignored packages from update counts
- Update check_updates() to pipe helper output through filter_ignored
- Fix false failure when all packages are filtered (grep exit code 1)
- Initialize HELPER variable to prevent unbound variable errors
@sejjy
Copy link
Copy Markdown
Owner

sejjy commented Apr 4, 2026

Hi,

I just have a few things to say.

First, I didn't know that checkupdates and AUR helpers don't filter ignored packages by default. I still have to test this.

Second, I see that you want to merge these commits into the fix/v0.14.0 branch, which is no longer updated since the issue it fixes was already resolved a few months back. The script has been updated on the main branch since then.

Lastly, it might be better to focus on one thing at a time. Maybe we could focus on filtering ignored packages first.

Thanks!

@oliviermilla
Copy link
Copy Markdown
Author

Hello,

Thank you for your response.

Your readme about installation details that if you are using waybar v°.14, you should use the fix/v0.14.0. Is the readme deprecated ? If it is the case I'll gladly move my PR to main and adapt if needed.

@sejjy
Copy link
Copy Markdown
Owner

sejjy commented Apr 30, 2026

After looking into it again, I’d say these commits are actually good improvements. Since fix/v0.14.0 is no longer being updated, moving your PR to main makes sense. Thanks!

@oliviermilla
Copy link
Copy Markdown
Author

I'll see what I can do. Meanwhile, there are pending PRs on main 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants