Commit 447d309
NBL Agent
v1.2.2: statistical validation hardening (FINAL_TEST leak fix + matched-card bootstrap + matched-seed rarity test)
FINAL_TEST leakage fixed (audit 2): model selection uses ONLY TRAIN+VALIDATION;
FINAL_TEST is a true holdout, never used for fairness/Spearman/candidate selection/
threshold/logistic/weights. VALIDATION fairness uses VALIDATION-internal disjoint
pairs only (audit 3). Pairwise + similar-BP split into train/validation/final
(audit 4/5); release reports pairwiseFinal 0.761 and similarBPFinal 0.543.
WinProbabilityModel: logistic fitted on TRAIN, VALIDATION sanity, FINAL only
Brier/LogLoss/bins/ECE (audit 6). All scripts use Object.keys(NCB.ARCHETYPES)
(7 archetypes incl. Support) (audit 7).
Adjacent-rarity matrix pseudo-replication fixed (audit 8/9/15): matched-card
bootstrap CI (statistical unit = independent card pair, not a battle); reports
battle/generatedCard/seed/pair counts; archetype-conditioned rows; DRAWS reported
separately (Support 'inversions' in v1.2.1 were Support-mirror stalemates, not
rarity losses). Matched-Seed Rarity Test added (audit 10/11): causal (matched)
0.75-0.85 and population 0.57-0.64, both 0 hard inversions (<40%) -> per audit 22
NO Generator v2 rebalance.
v1 fixture truly anchored to historical commit 19ca5a4 (audit 17/18): generated
from a temp worktree at that commit; generator refuses to run without
--historical-ref; tautological assertion removed (audit 19, count == 189).
Health metrics: n=2000, point + 95% CI + P50/P75/P90/P95 per archetype
(audit 20/21). stalemate 6.40% [5.41-7.56] exceeds the 5% point gate, driven by
Support/Tank mirror sustain loops; documented honestly (audit 21: long tail is not
a blocker; audit 24 A-E all satisfied), no hidden rebalance.
Version 1.2.2; 177 tests pass; npm run verify + calibration + matched-rarity +
adjacent matrix + similar-BP + health + browser QA (desktop/mobile) verified.1 parent b5d3079 commit 447d309
21 files changed
Lines changed: 3334 additions & 850 deletions
File tree
- docs
- qa
- scripts
- tests
- fixtures
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
121 | 122 | | |
122 | 123 | | |
123 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
124 | 129 | | |
125 | 130 | | |
126 | 131 | | |
127 | 132 | | |
128 | 133 | | |
129 | 134 | | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
140 | 147 | | |
141 | 148 | | |
142 | 149 | | |
| |||
146 | 153 | | |
147 | 154 | | |
148 | 155 | | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
156 | 168 | | |
157 | 169 | | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
41 | 45 | | |
42 | 46 | | |
43 | 47 | | |
44 | | - | |
| 48 | + | |
45 | 49 | | |
46 | | - | |
47 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
48 | 53 | | |
49 | 54 | | |
50 | | - | |
51 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
52 | 60 | | |
53 | 61 | | |
54 | | - | |
| 62 | + | |
55 | 63 | | |
56 | | - | |
57 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
58 | 99 | | |
59 | 100 | | |
60 | 101 | | |
61 | | - | |
| 102 | + | |
62 | 103 | | |
63 | 104 | | |
64 | 105 | | |
65 | 106 | | |
66 | | - | |
67 | | - | |
68 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
69 | 110 | | |
70 | | - | |
| 111 | + | |
71 | 112 | | |
72 | | - | |
73 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
74 | 117 | | |
75 | 118 | | |
76 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
0 commit comments