Fix checkptr in AddString64#13
Closed
somnusfish wants to merge 1 commit into
Closed
Conversation
Contributor
|
hi @somnusfish thanks for a fix. I managed to slightly improve readability if you don't mind. You could take over my code in #14 or @achille-roussel may green light it as it is. |
Author
|
Hi @yerden , thanks for the feedback. I took over your code since it is much faster and better readable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue : #12
Root cause:
According to https://pkg.go.dev/unsafe#Pointer, Unlike in C, it is not valid to advance a pointer just beyond the end of its original allocation:
The original logic hit the edge case when the length of the string could be divided by 8.
Solution
Handle the edge case using if condition, please refer the code for details.
Testing
Local fuzz test.