2622 implement unit for global templates#2647
Open
kdp-cloud wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for specifying a unit for template attributes when importing global templates from JSON, integrating unit lookup into the ISA template extraction pipeline and verifying behavior via controller/job tests.
Changes:
- Extend ISA template attribute JSON schema(s) to allow a
unitfield. - Populate
TemplateAttribute.unit_idfrom the imported JSON during template extraction. - Add fixtures and tests covering unit import, missing unit, and invalid unit handling (job + controller flows).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/seek/isa_templates/template_extractor.rb |
Looks up Unit by symbol from JSON and assigns unit_id on extracted TemplateAttributes. |
lib/seek/isa_templates/template_attributes_schema.json |
Allows unit in production schema for template attributes. |
lib/seek/isa_templates/template_attributes_schema_test.json |
Allows unit in test schema for template attributes. |
test/unit/jobs/populate_templates_job_test.rb |
Adds unit-related job tests (valid unit, missing unit, invalid unit). |
test/functional/templates_controller_test.rb |
Adds controller tests for create/update with unit and JSON upload population including unit. |
test/fixtures/files/upload_json_sample_type_template/test_unit_template.json |
New fixture template JSON including "unit": "g". |
test/fixtures/files/upload_json_sample_type_template/invalid_unit_template.json |
New fixture template JSON including an invalid unit symbol. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2622
Implements the unit field when uploading a global template JSON file.