feat: add setting to toggle clipboard key on keyboard#646
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Edited the commit message as this won't close the issue :) Or maybe we can commit to this once the floating keyboard is done and close the issue then. Regardless, @prince-0408, would you be able to look into the errors above? |
|
Hi @andrewtavis, I have updated the branch with the requested fixes:
Please let me know if there is anything else needed! |
|
Thanks, @prince-0408! We'll check this in the coming days :) |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's looking great here, @prince-0408! Thanks for focusing on the full usability of the keyboard. I think that this and similar options are really going to help the release go well 😊
Description
Related #642.
This PR adds a setting to the Layout section of the keyboard settings that allows users to toggle the visibility of the clipboard key on the keyboard UI.
Per the requirements:
Proposed Changes
Resources & i18n
string.xml(i18n.app.settings.keyboard.layout.clipboard_on_keyboardandi18n.app.settings.keyboard.layout.clipboard_on_keyboard_description).Preferences & State
getIsClipboardKeyEnabledandsetClipboardKeyPreferenceto save/retrieve user preference in SharedPreferences.SwitchItemtoggle for the clipboard setting inside the Layout settings list.Keyboard Rendering
KeyboardContextProviderwithisClipboardKeyEnabled()and wrapped the clipboard key layout block inadjustSpaceKeyWidthAndPositionto check this value.isClipboardKeyEnabled()to return the user's preference state.Verification
Screenshots