Skip to content

BUG: amos.h: fix translation errors in asyi, unk1, and besi #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbourgey merged 4 commits into from
Jun 4, 2026
Merged

BUG: amos.h: fix translation errors in asyi, unk1, and besi #158

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cffe98c
BUG: amos.h: fix translation errors in asyi and unk1
JaRoSchm May 20, 2026
5bc1a73
BUG: amos.h: fix translation bug in besi
JaRoSchm May 21, 2026
407de9e
TST: regression test for fix of besi
JaRoSchm May 21, 2026
6e495be
TST: regression test for fix of asyi
JaRoSchm Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions include/xsf/amos/amos.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,7 @@ namespace amos {
return nz;
}
ck = std::exp(cz);
for (int i = 0; i < (nn + 1); i++) {
for (int i = 0; i < nn; i++) {

@JaRoSchm JaRoSchm May 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/scipy/scipy/blob/4edfcaa3ce8a387450b6efce968572def71be089/scipy/special/amos/zasyi.f#L153.

y[i] *= ck;
}
/* 90 */
Expand Down Expand Up @@ -5622,7 +5622,7 @@ namespace amos {
return -1;
}
nz = n;
for (i = 0; i < (n + 1); i++) {
for (i = 0; i < n; i++) {

@JaRoSchm JaRoSchm May 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/scipy/scipy/blob/4edfcaa3ce8a387450b6efce968572def71be089/scipy/special/amos/zunk1.f#L185.

y[i] = 0.0;
}
return nz;
Expand Down Expand Up @@ -6067,8 +6067,7 @@ namespace amos {
// REFINE ESTIMATE AND TEST
//
aphi = std::abs(phid);
aarg = std::abs(argd);
rs1 += std::log(aphi) - 0.25 * std::log(aarg) - aic;
rs1 += std::log(aphi);

@JaRoSchm JaRoSchm May 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/scipy/scipy/blob/4edfcaa3ce8a387450b6efce968572def71be089/scipy/special/amos/zunk2.f#L234.

if (std::fabs(rs1) < elim) {
goto L120;
}
Expand Down
Loading