CI: hopefully get CuPy CI working and passing. - #148
Merged
Conversation
- prior cupy's used C++11 in core._create_ufunc, but we need C++17 for CUDA 13 which is what's on the runner.
Contributor
|
Thanks @steppi ! Should we try to increase GPU test coverage? |
Member
Author
Let's focus on having coverage for everything which is currently being used in CuPy, and incrementally adding coverage as things are added to CuPy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
What does this implement/fix?
I noticed here, #144 (comment), that GPU CI actually ran in my latest push to #144. The change I made prior to this was updating the runner to Ubuntu 24.04. It seems that runner has CUDA version 13 on it, but the pixi.toml had has pinned to an earlier CuPy. This PR enforces at least CuPy 14 in the cupy-tests env. I had changed
cupy._core._create_ufuncto use C++17 here (https://github.com/cupy/cupy/pull/9159/changes#diff-c9774fcecad94645bff3e07659c8eb24857a7bd1a08418651d430a42d3014f9c) which made it into the CuPy 14 release. C++17 is required for xsf, so CuPy 14 is the correct minimum CuPy version.Additional information
AI Generation Disclosure
No AI