BUG: amos.h: fix bugs in buni, uni1, uoik#145
Merged
Conversation
JaRoSchm
commented
May 11, 2026
| xx = std::real(z); | ||
| yy = std::imag(z); | ||
| ax = std::fabs(xx) + std::sqrt(3.); | ||
| ax = std::fabs(xx) * std::sqrt(3.); |
Contributor
Author
There was a problem hiding this comment.
JaRoSchm
commented
May 11, 2026
| /* 80 */ | ||
| if (nd > 2) { | ||
| rz = 1.0 / z; | ||
| rz = 2.0 / z; |
Contributor
Author
There was a problem hiding this comment.
JaRoSchm
commented
May 11, 2026
| zn = -zr * std::complex<double>(0, 1); | ||
| if (yy <= 0.) { | ||
| zn = std::conj(zn); | ||
| zn.real(-zn.real()); |
Contributor
Author
There was a problem hiding this comment.
JaRoSchm
commented
May 11, 2026
| if (rcz > -elim) { | ||
| ascle = 1e3 * d1mach[0] / tol; | ||
| cz = std::log(phi); | ||
| cz += std::log(phi); |
Contributor
Author
There was a problem hiding this comment.
JaRoSchm
commented
May 11, 2026
| ax = std::exp(rcz) / tol; | ||
| ay = std::imag(cz); | ||
| cz = ax * (std::cos(ay) + std::sin(ay * std::complex<double>(0, 1))); | ||
| cz = ax * (std::cos(ay) + std::sin(ay) * std::complex<double>(0, 1)); |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
What does this implement/fix?
Fixes translation bugs in the functions
buni,uni1, anduoikinamos.h. These led to wrong results forbesjwithz = -50.0 - 50.0j, fnu = 0.0, kode = 1, n = 1000. I have also added a test inspired by #92 (comment), which fails on main but passes on this branch. I replaced the test from #138 with this approach here and added the new test case, as this is much simpler going forward compared to the old approach.Additional information
AI Generation Disclosure